Long method smell

From CSSEMediaWiki
(Difference between revisions)
Jump to: navigation, search
Line 3: Line 3:
 
The Long method code smell is a sign that you possibly need to take some part of related functionality in your method and create a new method to hold this functionality. This action is known as the [http://www.refactoring.com/catalog/extractMethod.html Extract Method]
 
The Long method code smell is a sign that you possibly need to take some part of related functionality in your method and create a new method to hold this functionality. This action is known as the [http://www.refactoring.com/catalog/extractMethod.html Extract Method]
  
Comments in your method are sometimes a good sign that you need to extract the block of code that has been commented into a new method whose name describes the functionality that the comment was originally describing. Even if a single line of code requires explanation then it is probably worth extracting it into a new method. [http://sis36.berkeley.edu/projects/streek/agile/bad-smells-in-code.html#Long+Method 1]
+
Comments in your method are sometimes a good sign that you need to extract the block of code that has been commented into a new method whose name describes the functionality that the comment was originally describing. Even if a single line of code requires explanation then it is probably worth extracting it into a new method. [http://sis36.berkeley.edu/projects/streek/agile/bad-smells-in-code.html#Long+Method (1)]
  
 
== References ==
 
== References ==
  
 
1. [http://sis36.berkeley.edu/projects/streek/agile/bad-smells-in-code.html#Long+Method Bad Smells in Code - A Summary of Martin Fowler's Code Smell Chapter in "Refactoring"]
 
1. [http://sis36.berkeley.edu/projects/streek/agile/bad-smells-in-code.html#Long+Method Bad Smells in Code - A Summary of Martin Fowler's Code Smell Chapter in "Refactoring"]

Revision as of 05:20, 29 July 2008

"Object programs live best and longest with short methods. The payoffs of indirection - explanation, sharing and choosing - are supported by little methods. Everybody knows short is good." (1)

The Long method code smell is a sign that you possibly need to take some part of related functionality in your method and create a new method to hold this functionality. This action is known as the Extract Method

Comments in your method are sometimes a good sign that you need to extract the block of code that has been commented into a new method whose name describes the functionality that the comment was originally describing. Even if a single line of code requires explanation then it is probably worth extracting it into a new method. (1)

References

1. Bad Smells in Code - A Summary of Martin Fowler's Code Smell Chapter in "Refactoring"

Personal tools