Switch statement smell
m (category) |
m |
||
| Line 12: | Line 12: | ||
== See also == | == See also == | ||
* [[Code smells]] | * [[Code smells]] | ||
| + | * [[Beware type switches]] | ||
[[Category:Code smells]] | [[Category:Code smells]] | ||
Revision as of 03:14, 27 September 2009
One of the benefits of Object oriented design is the reduction in the need for switch statements. These can take the form of many if statements or, with better procedural style, a case statement. These statements tend to be repeated throughout the code if they exist making maintenance and editing or extending difficult.
If there is a switch statement smell it is an indication that refactoring is necessary. There are several different situations that will bring about the switch statement smell and each one has a different solution as documented by Martin Fowler 1999.
As explained by Fowler the solution to the switch statement problem is to use polymorphism.
The Type Switch:
If the type of an object is being checked to see what process should be applied the solution is to apply extract method and then move method.
